Redundancy in “if (x == TRUE)”

Last year when I was at JSM, I attended an excellent talk by Nicholas Horton and later nitpicked his R code:

ifelse(dest == "ORD" | dest == "MDW", TRUE, FALSE)

There is no need to use ifelse() here. The code above is equivalent to:

dest == "ORD" | dest == "MDW"

I have a feeling that some people are not comfortable when they think about Boolean values without literally seeing the values TRUE or FALSE. I think this is understandable. Personally I try to avoid redundancy, unless I’m explicitly thinking of the Department of Redundancy Department.

I also often see people write code like if (x == TRUE). The == TRUE part is redundant in my eyes: if (x) is enough. I think there is a slight visual benefit of explicitly comparing x with TRUE, though. That is, when glancing at the code, you can quickly know there is a Boolean comparison here, because the keyword TRUE is visually prominent.

A few minutes ago I saw yet another example of redundancy in the article “Flawed code served as icing on the cake for Prime Minister’s social agency launch”. The last line of the R code on the cake was like:

minister_greeting = ifelse(welcomeSpeech == TRUE, "....")

This line was quite interesting in several aspects:

1. It is flawed because the third argument of the ifelse() function was missing (with no default).

2. Again, there is redundancy in welcomeSpeech == TRUE: ifelse(welcomeSpeech) suffices. However, I think this redundancy is understandable since the cake is for someone who (I assume) do not really know much about R, and ifelse(welcomeSpeech == TRUE) may make the code a little more readable to them.

3. The author of this piece of code used the left arrow <- for assignments on all previous lines, but changed to the equal sign = on the last line. As you all probably know, I use the euqal sign all the time (except when I collaborate with someone who insists on using the arrow), so I’d like to say “Welcome to the dark side and long live the equal sign!”

4. Similarly, the author used snake_case everywhere, and suddenly changed to camelCase when naming the variable welcomeSpeech. Consistency is hard.

Donate

As a freelancer (currently working as a contractor) and a dad of three kids, I truly appreciate your donation to support my writing and open-source software development! Your contribution helps me cope with financial uncertainty better, so I can spend more time on producing high-quality content and software. You can make a donation through methods below.

• Venmo: @yihui_xie, or Zelle: xie@yihui.name

• Paypal

  • If you have a Paypal account, you can follow the link https://paypal.me/YihuiXie or find me on Paypal via my email xie@yihui.name. Please choose the payment type as “Family and Friends” (instead of “Goods and Services”) to avoid extra fees.

  • If you don’t have Paypal, you may donate through this link via your debit or credit card. Paypal will charge a fee on my side.

• Other ways:

  WeChat Pay (微信支付：谢益辉)	Alipay (支付宝：谢益辉)

When sending money, please be sure to add a note “gift” or “donation” if possible, so it won’t be treated as my taxable income but a genuine gift. Needless to say, donation is completely voluntary and I appreciate any amount you can give.

Please feel free to email me if you prefer a different way to give. Thank you very much!

I’ll give back a significant portion of the donations to the open-source community and charities. For the record, I received about $30,000 in total (before tax) in 2024-25, and gave back about $15,000 (after tax).